aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJiyong Park <jiyong@google.com>2017-09-06 12:10:07 +0900
committerCosme Domínguez Díaz <cosme.ddiaz@gmail.com>2018-04-22 11:54:16 +0200
commite330e9795d024b3b190159dadffe41e71146d0ff (patch)
tree38eed1c55f50a637c39b71c9d1989a2a5722e6ee
parentce3968b55ae8712a60a97fb95f49a90b1f74ef7f (diff)
Don't rely on transitively included headers
One must explicitly include what it need. time.h for struct tm. sys/time.h for gettimeofday, etc. Bug: 37629934 Test: build Merged-In: Iacd5317d958f61df062fca40fbf2e8992c7fbb44 Change-Id: I19e1043f23dbe85836b73714a4f1440159ebe419
-rw-r--r--gps/gnss/XtraSystemStatusObserver.cpp1
-rw-r--r--gps/utils/loc_log.cpp1
-rw-r--r--gps/utils/platform_lib_abstractions/loc_pla/src/platform_lib_log_util.cpp1
3 files changed, 3 insertions, 0 deletions
diff --git a/gps/gnss/XtraSystemStatusObserver.cpp b/gps/gnss/XtraSystemStatusObserver.cpp
index 2855c0d..e27e698 100644
--- a/gps/gnss/XtraSystemStatusObserver.cpp
+++ b/gps/gnss/XtraSystemStatusObserver.cpp
@@ -32,6 +32,7 @@
#include <sys/un.h>
#include <errno.h>
#include <ctype.h>
+#include <unistd.h>
#include <cutils/properties.h>
#include <math.h>
#include <arpa/inet.h>
diff --git a/gps/utils/loc_log.cpp b/gps/utils/loc_log.cpp
index 9fad9e6..fd9a236 100644
--- a/gps/utils/loc_log.cpp
+++ b/gps/utils/loc_log.cpp
@@ -32,6 +32,7 @@
#include <stdio.h>
#include <stdlib.h>
#include <sys/time.h>
+#include <time.h>
#include "loc_log.h"
#include "msg_q.h"
#include <platform_lib_includes.h>
diff --git a/gps/utils/platform_lib_abstractions/loc_pla/src/platform_lib_log_util.cpp b/gps/utils/platform_lib_abstractions/loc_pla/src/platform_lib_log_util.cpp
index 1c5762b..90bf26d 100644
--- a/gps/utils/platform_lib_abstractions/loc_pla/src/platform_lib_log_util.cpp
+++ b/gps/utils/platform_lib_abstractions/loc_pla/src/platform_lib_log_util.cpp
@@ -26,6 +26,7 @@
* IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include <cstdio>
+#include <sys/time.h>
#include "platform_lib_log_util.h"
#include "platform_lib_macros.h"