From d5d9fdf4ca089b5a7110c2991e6ba91bc553eca9 Mon Sep 17 00:00:00 2001 From: Sahitya Tummala Date: Fri, 30 Jun 2017 00:06:25 +0000 Subject: mm/list_lru.c: fix list_lru_count_node() to be race free list_lru_count_node() iterates over all memcgs to get the total number of entries on the node but it can race with memcg_drain_all_list_lrus(), which migrates the entries from a dead cgroup to another. This can return incorrect number of entries from list_lru_count_node(). Fix this by keeping track of entries per node and simply return it in list_lru_count_node(). Change-Id: I19e3b527804e95be75f48ee363c8207c0e7ee2ff Link: http://lkml.kernel.org/r/1498707555-30525-1-git-send-email-stummala@codeaurora.org Signed-off-by: Sahitya Tummala Cc: Jan Kara Cc: Vladimir Davydov Cc: Alexander Polakov Cc: Al Viro Patch-mainline: linux-mm @ 29/06/17, 09:09:15 Signed-off-by: Andrew Morton --- include/linux/list_lru.h | 1 + 1 file changed, 1 insertion(+) (limited to 'include/linux') diff --git a/include/linux/list_lru.h b/include/linux/list_lru.h index 2a6b9947aaa3..743b34f56f2b 100644 --- a/include/linux/list_lru.h +++ b/include/linux/list_lru.h @@ -44,6 +44,7 @@ struct list_lru_node { /* for cgroup aware lrus points to per cgroup lists, otherwise NULL */ struct list_lru_memcg *memcg_lrus; #endif + long nr_items; } ____cacheline_aligned_in_smp; struct list_lru { -- cgit v1.2.3