From 7996822bbce7a8fe70eeca22baa52eb4eaeeabbe Mon Sep 17 00:00:00 2001 From: Deepak Kumar Date: Tue, 7 Jun 2016 15:32:15 +0530 Subject: msm: kgsl: Correct dma_buf_get function return value check Check the return value of dma_buf_get function using IS_ERR_OR_NULL as dma_buf_get function can return ERR_PTR(-EINVAL) which won't be caught by simple NULL check. This will avoid kernel panic due to invalid pointer access. CRs-Fixed: 1008517 Change-Id: I11ebf618edd25a251d3fb8bb7fbbb886e10d788f Signed-off-by: Deepak Kumar --- drivers/gpu/msm/kgsl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/gpu') diff --git a/drivers/gpu/msm/kgsl.c b/drivers/gpu/msm/kgsl.c index 7dcb4df9607d..66c8755939a1 100644 --- a/drivers/gpu/msm/kgsl.c +++ b/drivers/gpu/msm/kgsl.c @@ -2144,8 +2144,8 @@ static int kgsl_setup_dmabuf_useraddr(struct kgsl_device *device, } up_read(¤t->mm->mmap_sem); - if (dmabuf == NULL) - return -ENODEV; + if (IS_ERR_OR_NULL(dmabuf)) + return dmabuf ? PTR_ERR(dmabuf) : -ENODEV; ret = kgsl_setup_dma_buf(device, pagetable, entry, dmabuf); if (ret) { -- cgit v1.2.3