From f1d327ea703cc29e69ca0d47b239d7e18befd0fa Mon Sep 17 00:00:00 2001 From: Himanshu Agarwal Date: Tue, 21 Mar 2017 14:05:10 +0530 Subject: qcacmn: Remove unnecessary QDF_ASSERT to avoid watchdog bark When bufs needed to post in a CE ring reaches (max no. of entries - 1), assert happens to print the dumpstack in kmsg. Once this condition is reached, a work is scheduled to recover CE from this OOM condition which tries to post buffers in CE. If buf posting fails again, assert will happen and work will be scheduled again. So, if system is in low memory situation, then buf allocation and posting will fail leading to assert and work scheduling again and again in a cycle. Due to these continuous dumpstacks in kmsg as a result of QDF_ASSERT(), watchdog bark is happening. Remove QDF_ASSERT from hif_post_recv_buffers_failure() as suffcient prints and history is present to indicate the situation and so there is no need of any kind of dumpstack in kmsg. Change-Id: Ib8bafb9a9fe45c62a15c45fa8a610da2074e058c CRs-Fixed: 2021793 --- hif/src/ce/ce_main.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hif/src/ce/ce_main.c b/hif/src/ce/ce_main.c index fa7d5eacf104..563d4c94b8a8 100644 --- a/hif/src/ce/ce_main.c +++ b/hif/src/ce/ce_main.c @@ -1685,11 +1685,9 @@ static void hif_post_recv_buffers_failure(struct HIF_CE_pipe_info *pipe_info, * there is no trigger to refill the ce and we will * eventually crash */ - if (bufs_needed_tmp == CE_state->dest_ring->nentries - 1) { - - QDF_ASSERT(0); + if (bufs_needed_tmp == CE_state->dest_ring->nentries - 1) qdf_sched_work(scn->qdf_dev, &CE_state->oom_allocation_work); - } + } -- cgit v1.2.3 From d32281348a504174c52aa4aa967d8fe336322ce8 Mon Sep 17 00:00:00 2001 From: Sandeep Puligilla Date: Thu, 23 Mar 2017 04:46:46 -0700 Subject: Release 5.1.1.2B Release 5.1.1.2B Change-Id: Ib37b5b3287214c7ed1897c4a81a5a203f9824547 CRs-Fixed: 688141 --- VERSION.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/VERSION.txt b/VERSION.txt index aed472ee9aec..9003b21134d6 100644 --- a/VERSION.txt +++ b/VERSION.txt @@ -1 +1 @@ -Current Component wlan-cmn.driver.lnx.1.0 version 5.1.1.2A +Current Component wlan-cmn.driver.lnx.1.0 version 5.1.1.2B -- cgit v1.2.3 From a61f839680ab14f89b5ecb0f09f8f53cb4f71017 Mon Sep 17 00:00:00 2001 From: "Poddar, Siddarth" Date: Thu, 16 Mar 2017 14:56:29 +0530 Subject: qcacmn: TXRX: Reduce the log spam in Kmsg Introduce different ol_trxrx print apis based on log levels. Therefore ol_txrx_print_level_set api is not needed anymore. Change-Id: I15f2c9d236ec55dd75b83a8336f918a0ef565c19 CRs-Fixed: 2019280 --- dp/inc/cdp_txrx_cmn.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/dp/inc/cdp_txrx_cmn.h b/dp/inc/cdp_txrx_cmn.h index 15cd1b84ad72..96ab2f7e5926 100644 --- a/dp/inc/cdp_txrx_cmn.h +++ b/dp/inc/cdp_txrx_cmn.h @@ -394,8 +394,6 @@ void ol_txrx_fw_stats_cfg( uint8_t cfg_stats_type, uint32_t cfg_val); -void ol_txrx_print_level_set(unsigned level); - #define TXRX_FW_STATS_TXSTATS 1 #define TXRX_FW_STATS_RXSTATS 2 #define TXRX_FW_STATS_RX_RATE_INFO 3 -- cgit v1.2.3 From 1250e5aa4df809ad94d2e81b7e1757abc5587d9f Mon Sep 17 00:00:00 2001 From: Sandeep Puligilla Date: Fri, 24 Mar 2017 09:06:57 -0700 Subject: Release 5.1.1.2C Release 5.1.1.2C Change-Id: Idf94e6b41716ffceb5de1042e18cc3160d408200 CRs-Fixed: 688141 --- VERSION.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/VERSION.txt b/VERSION.txt index 9003b21134d6..bd700fe15e15 100644 --- a/VERSION.txt +++ b/VERSION.txt @@ -1 +1 @@ -Current Component wlan-cmn.driver.lnx.1.0 version 5.1.1.2B +Current Component wlan-cmn.driver.lnx.1.0 version 5.1.1.2C -- cgit v1.2.3