From 224ebe8dddb50fb166d00b4d8b769f92b5d56591 Mon Sep 17 00:00:00 2001 From: SaidiReddy Yenuga Date: Thu, 21 Jul 2016 16:18:10 +0530 Subject: qcacld-3.0: Don't log if netlink_broadcast fails with error -ESRCH qcacld-2.0 to qcacld-3.0 propagation Don't log if netlink_broadcast fails with error -ESRCH(-3) since this error is likely to occur because of no listening process in the user space. In this case, error logs would give a false impression that feature is broken though feature is working fine. Change-Id: Ia111476e44a3dce24afd6b935ff0eca06accc73a CRs-Fixed: 989515 --- core/utils/fwlog/dbglog_host.c | 6 +++--- core/utils/nlink/src/wlan_nlink_srv.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/core/utils/fwlog/dbglog_host.c b/core/utils/fwlog/dbglog_host.c index 599a5cb2e82e..b77342f042d7 100644 --- a/core/utils/fwlog/dbglog_host.c +++ b/core/utils/fwlog/dbglog_host.c @@ -1643,7 +1643,7 @@ int send_fw_diag_nl_data(const uint8_t *buffer, A_UINT32 len, memcpy(nlmsg_data(nlh) + sizeof(radio), buffer, len); res = nl_srv_bcast(skb_out); - if (res < 0) { + if ((res < 0) && (res != -ESRCH)) { AR_DEBUG_PRINTF(ATH_DEBUG_RSVD1, ("%s: nl_srv_bcast failed 0x%x\n", __func__, res)); @@ -1743,7 +1743,7 @@ send_diag_netlink_data(const uint8_t *buffer, A_UINT32 len, A_UINT32 cmd) memcpy(slot->payload, buffer, len); res = nl_srv_bcast(skb_out); - if (res < 0) { + if ((res < 0) && (res != -ESRCH)) { AR_DEBUG_PRINTF(ATH_DEBUG_RSVD1, ("%s: nl_srv_bcast failed 0x%x\n", __func__, res)); @@ -1803,7 +1803,7 @@ dbglog_process_netlink_data(wmi_unified_t wmi_handle, const uint8_t *buffer, memcpy(slot->payload, buffer, len); res = nl_srv_bcast(skb_out); - if (res < 0) { + if ((res < 0) && (res != -ESRCH)) { AR_DEBUG_PRINTF(ATH_DEBUG_RSVD1, ("%s: nl_srv_ucast failed 0x%x\n", __func__, res)); diff --git a/core/utils/nlink/src/wlan_nlink_srv.c b/core/utils/nlink/src/wlan_nlink_srv.c index cf50721723aa..cc55b5308bad 100644 --- a/core/utils/nlink/src/wlan_nlink_srv.c +++ b/core/utils/nlink/src/wlan_nlink_srv.c @@ -377,7 +377,7 @@ int nl_srv_bcast(struct sk_buff *skb) err = netlink_broadcast(nl_srv_sock, skb, 0, WLAN_NLINK_MCAST_GRP_ID, flags); - if (err < 0) { + if ((err < 0) && (err != -ESRCH)) { QDF_TRACE(QDF_MODULE_ID_HDD, QDF_TRACE_LEVEL_WARN, "NLINK: netlink_broadcast failed err = %d", err); } -- cgit v1.2.3