From 9e245dfd3e3eab00f550c4e4b22677c23145a33e Mon Sep 17 00:00:00 2001 From: Davide Garberi Date: Sat, 6 Oct 2018 00:53:46 +0200 Subject: fpc1020: Simplify values checking * Don't use == 0 or == 1 Signed-off-by: Davide Garberi --- drivers/fingerprint/fpc1020_ree.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/fingerprint/fpc1020_ree.c b/drivers/fingerprint/fpc1020_ree.c index a120a2ff6a81..2a3b416bc00a 100644 --- a/drivers/fingerprint/fpc1020_ree.c +++ b/drivers/fingerprint/fpc1020_ree.c @@ -102,9 +102,9 @@ static ssize_t irq_set(struct device *device, struct fpc1020_data *fpc1020 = dev_get_drvdata(device); retval = kstrtou64(buffer, 0, &val); - if (val == 1) + if (val) enable_irq(fpc1020->irq); - else if (val == 0) + else if (!val) disable_irq(fpc1020->irq); else return -ENOENT; @@ -166,7 +166,7 @@ static ssize_t proximity_state_set(struct device *dev, return -EINVAL; fpc1020->proximity_state = !!val; if (!fpc1020->screen_on) { - if (fpc1020->proximity_state == 1) { + if (fpc1020->proximity_state) { /* Disable IRQ when screen is off and proximity sensor is covered */ config_irq(fpc1020, false); } else if (fpc1020->wakeup_enabled) { @@ -195,7 +195,7 @@ static void fpc1020_report_work_func(struct work_struct *work) struct fpc1020_data *fpc1020 = NULL; fpc1020 = container_of(work, struct fpc1020_data, input_report_work); - if (fpc1020->screen_on == 1) { + if (fpc1020->screen_on) { pr_info("Report key value = %d\n", (int)fpc1020->report_key); input_report_key(fpc1020->input_dev, fpc1020->report_key, 1); input_sync(fpc1020->input_dev); -- cgit v1.2.3