From 6c9ffda7c04766cfa18d14752c38e457db323c2c Mon Sep 17 00:00:00 2001 From: Naveen Rawat Date: Thu, 17 Nov 2016 11:38:21 -0800 Subject: qcacld-3.0: Add NULL pointers check before access in csr_api_roam.c Add check for NULL for pointer before dereferencing them. Change-Id: Ieee249a3100a0aabf70bf79f0c81df8d8febb59b CRs-Fixed: 1091486 --- core/sme/src/csr/csr_api_roam.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/core/sme/src/csr/csr_api_roam.c b/core/sme/src/csr/csr_api_roam.c index 3b83e6f0d0fb..4affbe198695 100644 --- a/core/sme/src/csr/csr_api_roam.c +++ b/core/sme/src/csr/csr_api_roam.c @@ -11137,6 +11137,10 @@ csr_roam_chk_lnk_set_ctx_rsp(tpAniSirGlobal mac_ctx, tSirSmeRsp *msg_ptr) tpSirSetActiveModeSetBncFilterReq pMsg; pMsg = qdf_mem_malloc( sizeof(tSirSetActiveModeSetBncFilterReq)); + if (NULL == pMsg) { + sms_log(mac_ctx, LOGE, FL("Malloc failed")); + goto remove_entry_n_process_pending; + } pMsg->messageType = eWNI_SME_SET_BCN_FILTER_REQ; pMsg->length = sizeof(tSirSetActiveModeSetBncFilterReq); pMsg->seesionId = sessionId; @@ -11160,6 +11164,11 @@ csr_roam_chk_lnk_set_ctx_rsp(tpAniSirGlobal mac_ctx, tSirSmeRsp *msg_ptr) struct sme_obss_ht40_scanind_msg *msg; msg = qdf_mem_malloc(sizeof( struct sme_obss_ht40_scanind_msg)); + if (NULL == msg) { + sms_log(mac_ctx, LOGE, + FL("Malloc failed")); + goto remove_entry_n_process_pending; + } msg->msg_type = eWNI_SME_HT40_OBSS_SCAN_IND; msg->length = sizeof(struct sme_obss_ht40_scanind_msg); @@ -11197,6 +11206,7 @@ csr_roam_chk_lnk_set_ctx_rsp(tpAniSirGlobal mac_ctx, tSirSmeRsp *msg_ptr) session->isPrevApInfoValid = false; } #endif +remove_entry_n_process_pending: if (csr_ll_remove_entry(&mac_ctx->sme.smeCmdActiveList, entry, LL_ACCESS_LOCK)) csr_release_command_set_key(mac_ctx, cmd); -- cgit v1.2.3