From 64cdc7585d954917c8fd2fd27af0d6f317a86334 Mon Sep 17 00:00:00 2001 From: Laxminath Kasam Date: Wed, 24 May 2017 18:27:39 +0530 Subject: pinctrl: lpi: Avoid null pointer access in dbg_show In LPI GPIO dump API, assign pctldev with valid pointer to avoid null pointer access. CRs-Fixed: 2048264 Change-Id: I8f0caa39a87453ee2b6592d3f985c759240dd821 Signed-off-by: Laxminath Kasam --- drivers/pinctrl/qcom/pinctrl-lpi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/qcom/pinctrl-lpi.c b/drivers/pinctrl/qcom/pinctrl-lpi.c index 3fe41ee4c3c1..7704893d9b39 100644 --- a/drivers/pinctrl/qcom/pinctrl-lpi.c +++ b/drivers/pinctrl/qcom/pinctrl-lpi.c @@ -463,6 +463,7 @@ static void lpi_gpio_dbg_show_one(struct seq_file *s, "pull up" }; + pctldev = pctldev ? : to_gpio_state(chip)->ctrl; pindesc = pctldev->desc->pins[offset]; pad = pctldev->desc->pins[offset].drv_data; ctl_reg = lpi_gpio_read(pad, LPI_GPIO_REG_DIR_CTL); -- cgit v1.2.3