From 376e1111ab102886ba674e14562176ea72fcbd0a Mon Sep 17 00:00:00 2001 From: Nathan Chancellor Date: Fri, 27 Sep 2019 00:04:45 -0700 Subject: msm: mdss: Remove unnecessary parentheses in is_valid_calib_dspp_addr Clang warns: ../drivers/video/fbdev/msm/mdss_mdp_pp.c:6923:19: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] } else if ((ptr == base + MDSS_MDP_REG_DSPP_DITHER_DEPTH)) { ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/video/fbdev/msm/mdss_mdp_pp.c:6923:19: note: remove extraneous parentheses around the comparison to silence this warning } else if ((ptr == base + MDSS_MDP_REG_DSPP_DITHER_DEPTH)) { ~ ^ ~ ../drivers/video/fbdev/msm/mdss_mdp_pp.c:6923:19: note: use '=' to turn this equality comparison into an assignment } else if ((ptr == base + MDSS_MDP_REG_DSPP_DITHER_DEPTH)) { ^~ = Fixes: 94d860d801b8 ("msm: mdss: Support post processing blocks address access") Signed-off-by: Nathan Chancellor --- drivers/video/fbdev/msm/mdss_mdp_pp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/msm/mdss_mdp_pp.c b/drivers/video/fbdev/msm/mdss_mdp_pp.c index 4c606232ed81..7dba7e3cfc99 100644 --- a/drivers/video/fbdev/msm/mdss_mdp_pp.c +++ b/drivers/video/fbdev/msm/mdss_mdp_pp.c @@ -6921,7 +6921,7 @@ static int is_valid_calib_dspp_addr(char __iomem *ptr) ret = MDP_PP_OPS_READ | MDP_PP_OPS_WRITE; break; /* Dither enable/disable */ - } else if ((ptr == base + MDSS_MDP_REG_DSPP_DITHER_DEPTH)) { + } else if (ptr == base + MDSS_MDP_REG_DSPP_DITHER_DEPTH) { ret = MDP_PP_OPS_READ | MDP_PP_OPS_WRITE; break; /* Six zone and mem color */ -- cgit v1.2.3