From 2f64e3f96c311e179a1da50c1e21d2e256a0b1c8 Mon Sep 17 00:00:00 2001 From: Pawan Kumar Date: Tue, 5 Nov 2013 10:52:20 +0530 Subject: msm: mdss: Check ctl in mdss_mdp_mixer_get before using Put NULL check for ctl before using in mdss_mdp_mixer_get. Change-Id: Ia1bc035df46c9e237c244623e61a6802cf0d9110 Signed-off-by: Pawan Kumar --- drivers/video/fbdev/msm/mdss_mdp_ctl.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/msm/mdss_mdp_ctl.c b/drivers/video/fbdev/msm/mdss_mdp_ctl.c index 57c49930ec77..060d6419924f 100644 --- a/drivers/video/fbdev/msm/mdss_mdp_ctl.c +++ b/drivers/video/fbdev/msm/mdss_mdp_ctl.c @@ -1577,9 +1577,17 @@ int mdss_mdp_ctl_addr_setup(struct mdss_data_type *mdata, struct mdss_mdp_mixer *mdss_mdp_mixer_get(struct mdss_mdp_ctl *ctl, int mux) { struct mdss_mdp_mixer *mixer = NULL; - struct mdss_overlay_private *mdp5_data = mfd_to_mdp5_data(ctl->mfd); - if (!ctl) + struct mdss_overlay_private *mdp5_data = NULL; + if (!ctl || !ctl->mfd) { + pr_err("ctl not initialized\n"); return NULL; + } + + mdp5_data = mfd_to_mdp5_data(ctl->mfd); + if (!mdp5_data) { + pr_err("ctl not initialized\n"); + return NULL; + } switch (mux) { case MDSS_MDP_MIXER_MUX_DEFAULT: -- cgit v1.2.3