From 1d0e1f5ffb88b9e8dcc64ebead6064e91c2ca293 Mon Sep 17 00:00:00 2001 From: Yuanyuan Liu Date: Wed, 9 Nov 2016 11:34:45 -0800 Subject: qcacld-3.0: Extend WMA_RESUME_TIMEOUT to 25 secs If WLAN FW crashes while in suspend mode then kernel tries to resume the driver and WMA sends resume indication to WLAN FW and waits for the response from WLAN FW. Since FW is already crashed, there will not be any response from WLAN FW and wait logic waits for the timeout before bailing out. This may cause delay in completing the recovery and may cause other race conditions becuase of that. To solve this, we registered for shutdown notification so that call back would be called during recovery and resume event can be set to make sure resume thread doesn't just wait for the FW response. However, it takes around 7 ~ 12 secs for platform driver to receive PD down notification and trigger the recovery but wma only waits for 6 secs and still crashed before recovery started. The fix it to extend WMA_RESUME_TIMEOUT to 25 secs so that it can be interrupted gracefully by recovery call backs. CRs-Fixed: 1087911 Change-Id: Iba8b94111e4b4f0b0db8794e98c0645c667379a8 --- core/wma/inc/wma.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/wma/inc/wma.h b/core/wma/inc/wma.h index 83ef6f93cdd0..a6ddeef91dfe 100644 --- a/core/wma/inc/wma.h +++ b/core/wma/inc/wma.h @@ -60,7 +60,7 @@ #define WMA_SERVICE_READY_EXT_TIMEOUT 6000 #define WMA_TGT_SUSPEND_COMPLETE_TIMEOUT 6000 #define WMA_WAKE_LOCK_TIMEOUT 1000 -#define WMA_RESUME_TIMEOUT 6000 +#define WMA_RESUME_TIMEOUT 25000 #define MAX_MEM_CHUNKS 32 #define WMA_CRASH_INJECT_TIMEOUT 5000 -- cgit v1.2.3