summaryrefslogtreecommitdiff
path: root/drivers/soc/qcom (unfollow)
Commit message (Collapse)Author
2024-10-17Merge remote-tracking branch 'msm8998/lineage-20' into lineage-20Raghuram Subramani
Change-Id: I126075a330f305c85f8fe1b8c9d408f368be95d1
2024-03-22soc: qcom: smem: Add boundary checks for partitionsSarannya S
Add condition check to make sure that the end address of private entry does not go out of partition. Change-Id: Ifb942c30ebeb8bccb891eebdcae4700b64b76920 Signed-off-by: Sarannya S <quic_sarannya@quicinc.com>
2024-03-22Revert "soc: qcom: smem: Add boundary checks for partitions"Sarannya S
This reverts commit 71dc69707730a693c883a94f2d390299b49ea144. Reason for revert: Few boundary checks are missing Change-Id: Ib6783b43ad447fe5ebaed20a6e7908b96fb87fdf Signed-off-by: Sarannya S <quic_sarannya@quicinc.com>
2024-02-27soc: qcom: smem: Add boundary checks for partitionsSarannya S
Add condition check to make sure that the end address of private entry does not go out of partition. Change-Id: I88b3c69d86d90905b214c13a8c632b134b487a49 Signed-off-by: Sarannya S <quic_sarannya@quicinc.com> Signed-off-by: Pranav Mahesh Phansalkar <quic_pphansal@quicinc.com> (cherry picked from commit d3154be15b022817c95973d77d67411da3ea71ef)
2023-11-02icnss: Fix enum-conversion warning from ClangNathan Chancellor
../drivers/soc/qcom/icnss.c:3418:37: warning: implicit conversion from enumeration type 'enum icnss_driver_mode' to different enumeration type 'enum wlfw_driver_mode_enum_v01' [-Wenum-conversion] ret = wlfw_wlan_mode_send_sync_msg(mode); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~ 1 warning generated. Change-Id: I7ff0326411b4b2a6e020cf50bc655ec26c1e4992 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
2023-10-27msm: msm_bus: Fix strict-prototypes errorLuK1337
Change-Id: I756cfd498312be1ecc264576af8c874c89d93813
2023-10-27msm: qdsp6v2: Fix strict-prototypes errorLuK1337
Change-Id: I55fbab53a24e395a6f34c699d5b55ad38d023c24
2023-07-16kernel: power: Workaround for sensor ipc message causing high power consumeFrank Luo
Sync from Qcom's document KBA-180725024109 To avoid the non-wakeup type sensor data break the AP sleep flow, notify sensor subsystem in the first place of pm_suspend . Bug: 118418963 Test: measure power consumption after running test case Change-Id: I2848230d495e30ac462aef148b3f885103d9c24e Signed-off-by: Frank Luo <luofrank@google.com>
2022-11-01fixup! BACKPORT: treewide: Fix function prototypes for module_param_call()Nolen Johnson
Change-Id: Id4056255732a1865e4b97a443ba936a51954e407
2022-07-27icnss: Fix enum-conversion warning from ClangNathan Chancellor
../drivers/soc/qcom/icnss.c:3154:37: warning: implicit conversion from enumeration type 'enum icnss_driver_mode' to different enumeration type 'enum wlfw_driver_mode_enum_v01' [-Wenum-conversion] ret = wlfw_wlan_mode_send_sync_msg(mode); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~ 1 warning generated. Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
2022-07-27drivers: soc: qcom: fix register names on ARM64Greg Hackmann
gcc apparently lets you use r0, r1, etc. as register names even in aarch64 mode. clang does not. This change has no impact on the code generated by gcc (confirmed by disassembling scm.o with and without the patch). Change-Id: I8a7103738bb6603693287afd22c0346cb397458e Signed-off-by: Greg Hackmann <ghackmann@google.com> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
2022-07-27shenqi_nv: Add back bt_macDavide Garberi
* Useful in case we switch to non zui bluetooth blobs Change-Id: I29b5a37c40e0289744708ebb03985e6427c368a6
2022-07-27shenqi_nv: drop the useless dump_smem functiondev-harsh1998
* The dump_smem function more like a debug function which was implemented by the oem for debugging purposes but after the recent cleanup up DD3Boh/android_kernel_zuk_msm8996@4c947e4ab0bee7f79b3ab65132cf93749fb249b4 we now have proper fail checks so there is no need to have this function. * Kill it with fire and drop the expense cost of calling it, also cleanup whitespaces while we are at it. Signed-off-by: dev-harsh1998 <dev-harsh1998@hotmail.com>
2022-07-27shenqi_nv: Cleanup and rewriteYaroslav Furman
* Cleanup unneded stuff * Add proper fail checks * Remove unneded spaces and junk * Move to late_initcall * Remove bt_mac code as it's being read correctly without this kernel part Signed-off-by: Yaroslav Furman <yaro330@gmail.com> Signed-off-by: Davide Garberi <dade.garberi@gmail.com>
2022-07-27soc: qcom: Add shenqi_nv from ZUKDavide Garberi
* Needed to recognize the correct hardware wlan mac address * Slightly cleaned indentation Change-Id: Ic4db07c33b7de9cf2a8ca010a5d3d87427cf9b61
2022-07-27soc: qcom: Remove now unused MSM_SMP2P_TESTAlbert I
All related codes have been removed since commit c457926b166c introduced by LA.UM.7.2.r1-05400-sdm660.0 CAF tag. Signed-off-by: Albert I <krascgq@outlook.co.id> Signed-off-by: Davide Garberi <dade.garberi@gmail.com> Change-Id: I3d8e6ac169e2f2712ae839c6a67f8e288a4511de
2021-10-13soc: qcom: hab: Add sanity check for payload_countlixiang
When handling memory import, payload_count is used for memory alloc calculation. If the payload_count is too large, size will overflow when creating page list. Adding a sanity check for payload_count is necessary. Change-Id: I6d60cea0c62bd29092852c55b766b77a94cb6e3b Signed-off-by: lixiang <lixiang@codeaurora.org>
2021-07-23soc: qcom: Add check to handle out of bound accessKomal Bajaj
Adding check in msm_minidump_add_region() to handle scenarios for out of bound access while adding region in minidump table in SMEM. Change-Id: Ic20663dbd2fa8ae96899930a7f7ba79dc204ff5e Signed-off-by: Komal Bajaj <kbajaj@codeaurora.org> Signed-off-by: Srinivasarao P <spathi@codeaurora.org>
2020-10-30soc: qcom: service-locator: Free PD list after client useIsaac J. Manjarres
Currently, when a client invokes the service-locator to get the domain list for a service, a data structure is dynamically allocated to hold this information, and that is given to the client for use. However, after the client uses the domain list, the data structure is not freed, resulting in a memory leak. Free domain list data structure after client use to fix memory leak. Change-Id: I2b87afefbb35c2c296b4267450fa3152e3725ab9 Signed-off-by: Isaac J. Manjarres <isaacm@codeaurora.org>
2020-07-23Revert "drivers: soc: qcom: system_stats: Fix strlcpy usage"Michael Bestas
This reverts commit f4e569d56adbce58a324ec358a50b5fdd1108e11.
2020-07-23Revert "soc: qcom: msm_performance: Fix cpumask checks in init_cluster_control"Michael Bestas
This reverts commit 5645b93f8b4a4e8fb1ce3a3069cfef085c14ebd8.
2020-06-16soc: qcom: Reset string table index for each dump collection requestJitendra Sharma
Section name should be placed in String table. Currently, we used static version for string table index to update subsequent section names. Due to this string table index keeps on increasing during every new dump(subsystem restart) request. This ultimately will result in buffer overflow, leading to Redzone overwritten. Hence, as a fix, now reset, this string table index once dump capture is complete. Change-Id: Ibc2446ae4011db5291044eacdc1a1119597d862a Signed-off-by: Jitendra Sharma <shajit@codeaurora.org>
2020-06-03Revert "sysmon-qmi: Fix compilation error while using LLVM"Michael Bestas
* We'll take the upstream fix This reverts commit 722c2dfad791dfca2b0517b32930be75b69a6581. Change-Id: I761a1c765b85c91bf1d01873f2773c288dd346cf
2020-06-03Revert "soc: qcom: access smp2p_smem structure with I/O function"Michael Bestas
* We'll take the upstream fix This reverts commit affbb18601e38b841cbb25f8c32f35a47772c41a. Change-Id: I9f3c45651495d4c44a1595e3226b4256eb90015c
2020-06-03Revert "soc: qcom: rpm_master_stat: Fix strlcpy usage"Michael Bestas
* We'll take the upstream fix This reverts commit 15457b9a920613a525640e57305f8f04606ac5cb. Change-Id: I1f67bd6eb642a8cf8d376aa87a82796daad384ab
2020-06-03Revert "soc: qcom: msm-spm: Remove useless NULL check in ↵Michael Bestas
msm_spm_drv_flush_shadow" * We'll take the upstream fix This reverts commit 67c3cabf052b093c949e4fb1070ba416786e3960. Change-Id: I41b1e7968c7bbe0cd5d5343873dbc103842235aa
2020-06-03Revert "soc: qcom: glink_debugfs: Fix strlcpy usage"Michael Bestas
* We'll take the upstream fix This reverts commit 41030c7dd59d1ad70501d6edd51fae79279e626b. Change-Id: Ibe4cafd8cdda176ef0b2bef6c1f5e73da4bba704
2020-05-21kernel: Fix build errors with LLVMSwetha Chikkaboraiah
This patch intends to fix compilation errors while building kernel with LLVM toolchain. Change-Id: I76c4f97d8a0efb44434d54fb07cae23b050d2003 Signed-off-by: Swetha Chikkaboraiah <schikk@codeaurora.org>
2020-04-28soc: qcom: Fix strlcpy compilation error with clangNaitik Bharadiya
Replace size of source with size of the destination in strlcpy size argument to fix clang compilation error. Change-Id: Ia05e562b1524995b1aa98d934bcfa4d2c5642b70 Signed-off-by: Naitik Bharadiya <bharad@codeaurora.org> Signed-off-by: Swetha Chikkaboraiah <schikk@codeaurora.org>
2020-04-28sysmon-qmi: Fix compilation error while using LLVMShadab Naseem
LLVM compiler gave compilation error for directly dereferencing completion datatype for conditional check. "warning: address of 'data->ind_recv.done' will always evaluate to 'true' [-Wpointer-bool-conversion]" Use completion API to fix it. Change-Id: I985212802fe37d4b0ebe1b45e90f52d6213864f7 Signed-off-by: Shadab Naseem <snaseem@codeaurora.org> Signed-off-by: Swetha Chikkaboraiah <schikk@codeaurora.org>
2020-04-28soc: qcom: glink_debugfs: Fix compilation error with clangNaitik Bharadiya
use destination string size in strlcpy size argument to fix clang compilation error. Change-Id: Ice7fa2753d07e07c5c214ffb0792450985378643 Signed-off-by: Naitik Bharadiya <bharad@codeaurora.org> Signed-off-by: Swetha Chikkaboraiah <schikk@codeaurora.org>
2020-04-28driver : Fix warnings and errors with llvmNaitik Bharadiya
Fix pointer-bool-conversion, logical-not-parentheses errors and warnings with llvm. Change-Id: Idebfc5cd36af197e579bf8783e25069ae54f86f8 Signed-off-by: Naitik Bharadiya <bharad@codeaurora.org> Signed-off-by: Swetha Chikkaboraiah <schikk@codeaurora.org>
2020-04-28soc: qcom: access smp2p_smem structure with I/O functionArun Kumar Neelakantam
Accessing I/O memory pointers directly cause un-aligned access when using the clang compiler. Avoid using direct iomem pointer access instead use I/O functions. CRs-Fixed: 2410460 Change-Id: I041b10739049de26174e5536bbd142f1deeada3b Signed-off-by: Arun Kumar Neelakantam <aneela@codeaurora.org> Signed-off-by: Swetha Chikkaboraiah <schikk@codeaurora.org>
2020-04-24soc: qcom: smem: Use le32_to_cpu for comparisonChris Lew
[ Upstream commit a216000f0140f415cec96129f777b5234c9d142f ] Endianness can vary in the system, add le32_to_cpu when comparing partition sizes from smem. Signed-off-by: Chris Lew <clew@codeaurora.org> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Andy Gross <andy.gross@linaro.org> Signed-off-by: Lee Jones <lee.jones@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-02-02drivers: soc: qcom: system_stats: Fix strlcpy usageNathan Chancellor
Clang warns: ../drivers/soc/qcom/system_stats.c:381:13: warning: size argument in 'strlcpy' call appears to be size of the source; expected the size of the destination [-Wstrlcpy-strlcat-size] strlen(master_name) + 1); ~~~~~~~^~~~~~~~~~~~~~~~ Fixes: 1d321eb86c2f ("drivers: soc: qcom: system_stats: Support for System stats") Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
2020-02-02soc: qcom: rpm_master_stat: Fix strlcpy usageNathan Chancellor
Clang warns: ../drivers/soc/qcom/rpm_master_stat.c:400:13: warning: size argument in 'strlcpy' call appears to be size of the source; expected the size of the destination [-Wstrlcpy-strlcat-size] strlen(master_name) + 1); ~~~~~~~^~~~~~~~~~~~~~~~ 62a79b84fd85 ("qcom: Port rpm logs and stats driver from 3.18 to 4.4 kernel") Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
2020-02-02soc: qcom: msm_bus: Remove unnecessary self assignment in ↵Nathan Chancellor
msm_bus_dbg_update_request_write Clang warns: ../drivers/soc/qcom/msm_bus/msm_bus_dbg.c:580:11: warning: explicitly assigning value of variable of type 'struct msm_bus_cldata *' to itself [-Wself-assign] cldata = cldata; ~~~~~~ ^ ~~~~~~ 1 warning generated. Fixes: 8461868fb6ff ("platform: msm: msm_bus: Add support for bus scaling") Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
2020-02-02soc: qcom: msm-spm: Remove useless NULL check in msm_spm_drv_flush_shadowNathan Chancellor
Clang warns: ../drivers/soc/qcom/msm-spm.c:156:15: warning: address of array 'dev->reg_shadow' will always evaluate to 'true' [-Wpointer-bool-conversion] BUG_ON(!dev->reg_shadow); ~~~~~~^~~~~~~~~~ Fixes: de64ab2e8604 ("soc: spm: Snapshot of the SPM driver from 3.18 kernel") Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
2020-02-02soc: qcom: msm_performance: Fix cpumask checks in init_cluster_controlNathan Chancellor
Clang warns: ../drivers/soc/qcom/msm_performance.c:2731:28: warning: address of array 'managed_clusters[i]->offlined_cpus' will always evaluate to 'true' [-Wpointer-bool-conversion] if (managed_clusters[i]->offlined_cpus) ~~ ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~ ../drivers/soc/qcom/msm_performance.c:2733:28: warning: address of array 'managed_clusters[i]->cpus' will always evaluate to 'true' [-Wpointer-bool-conversion] if (managed_clusters[i]->cpus) ~~ ~~~~~~~~~~~~~~~~~~~~~^~~~ Use the cpumask_available helper that was added in commit f7e30f01a9e2 ("cpumask: Add helper cpumask_available()"). Fixes: 56f6d6c3529d ("soc: qcom: msm_perf: free allocated memory if error happens") Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
2020-02-02msm: msm_bus: Remove unnecessary parentheses in get_nodeNathan Chancellor
Clang warns: ../drivers/soc/qcom/msm_bus/msm_bus_rules.c:68:12: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] if ((id == NB_ID)) { ~~~^~~~~~~~ ../drivers/soc/qcom/msm_bus/msm_bus_rules.c:68:12: note: remove extraneous parentheses around the comparison to silence this warning if ((id == NB_ID)) { ~ ^ ~ ../drivers/soc/qcom/msm_bus/msm_bus_rules.c:68:12: note: use '=' to turn this equality comparison into an assignment if ((id == NB_ID)) { ^~ = ../drivers/soc/qcom/msm_bus/msm_bus_rules.c:69:24: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] if ((node_it->data == data)) { ~~~~~~~~~~~~~~^~~~~~~ ../drivers/soc/qcom/msm_bus/msm_bus_rules.c:69:24: note: remove extraneous parentheses around the comparison to silence this warning if ((node_it->data == data)) { ~ ^ ~ ../drivers/soc/qcom/msm_bus/msm_bus_rules.c:69:24: note: use '=' to turn this equality comparison into an assignment if ((node_it->data == data)) { ^~ = Fixes: 8461868fb6ff ("platform: msm: msm_bus: Add support for bus scaling") Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
2020-02-02soc: q6dspv2: apr: Remove unnecessary parentheses in is_valid_calib_dspp_addrNathan Chancellor
../drivers/soc/qcom/qdsp6v2/apr.c:751:17: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] if ((domain_id == APR_DOMAIN_ADSP)) { ~~~~~~~~~~^~~~~~~~~~~~~~~~~~ ../drivers/soc/qcom/qdsp6v2/apr.c:751:17: note: remove extraneous parentheses around the comparison to silence this warning if ((domain_id == APR_DOMAIN_ADSP)) { ~ ^ ~ ../drivers/soc/qcom/qdsp6v2/apr.c:751:17: note: use '=' to turn this equality comparison into an assignment if ((domain_id == APR_DOMAIN_ADSP)) { ^~ = 1 warning generated. Fixes: be1a516dcb85 ("ASoC: msm: Add Audio drivers for MSM targets") Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
2020-02-02sysmon-qmi: Fix compilation error while using LLVMShadab Naseem
LLVM compiler gave compilation error for directly dereferencing completion datatype for conditional check. "warning: address of 'data->ind_recv.done' will always evaluate to 'true' [-Wpointer-bool-conversion]" Use completion API to fix it. Change-Id: I985212802fe37d4b0ebe1b45e90f52d6213864f7 Signed-off-by: Shadab Naseem <snaseem@codeaurora.org> Link: https://source.codeaurora.org/quic/la/kernel/msm-4.9/commit/?id=e4aa68bc79aaa21ed7b1cf93daf7f2268c7f7ad4 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
2020-02-02soc: qcom: glink_debugfs: Fix strlcpy usageNathan Chancellor
Clang warns: ../drivers/soc/qcom/glink_debugfs.c:562:18: warning: size argument in 'strlcpy' call appears to be size of the source; expected the size of the destination [-Wstrlcpy-strlcat-size] curr, strlen(curr) + 1); ~~~~~~~^~~~~~~~~ ../drivers/soc/qcom/glink_debugfs.c:562:11: note: change size argument to be the size of the destination curr, strlen(curr) + 1); ^~~~~~~~~~~~~~~~ sizeof(dbgfs_dent_s->self_name) ../drivers/soc/qcom/glink_debugfs.c:564:13: warning: size argument in 'strlcpy' call appears to be size of the source; expected the size of the destination [-Wstrlcpy-strlcat-size] strlen(par_dir) + 1); ~~~~~~~^~~~~~~~~~~~ ../drivers/soc/qcom/glink_debugfs.c:564:6: note: change size argument to be the size of the destination strlen(par_dir) + 1); ^~~~~~~~~~~~~~~~~~~ sizeof(dbgfs_dent_s->par_name) 2 warnings generated. Fixes: 987bbebd9aa6 ("soc: qcom: Add snapshot of G-Link driver") Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
2020-02-02soc: qcom: access smp2p_smem structure with I/O functionArun Kumar Neelakantam
Accessing I/O memory pointers directly cause un-aligned access when using the clang compiler. Avoid using direct iomem pointer access instead use I/O functions. CRs-Fixed: 2410460 Change-Id: I041b10739049de26174e5536bbd142f1deeada3b Signed-off-by: Arun Kumar Neelakantam <aneela@codeaurora.org> Link: https://source.codeaurora.org/quic/la/kernel/msm-4.9/commit/?id=f797c03b33fae49db9dde7dfe4289aa2efc07e0c Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
2019-12-23soc: qcom: haptic: Correct return value of show() methodsZhao Wei Liew
By convention, these methods should return the number of bytes actually written into the buffer, not the number of bytes that would have been written. Change-Id: Iab8b292397bf3cbbf4a59a72812d3831ac7722c4 Signed-off-by: Zhao Wei Liew <zhaoweiliew@gmail.com>
2019-12-23msm: qpnp-haptic: set up sysfs interface for common cmhw implementationdianlujitao
* Export vmax_mv as vtg_level * Add min/max/default voltage sysfs entries * Make min/max voltage adjustable via DT Change-Id: Iefa3accdb75fcef9bcb2d4c730ca0a72763994f3
2019-12-23msm: qpnp-haptic: Process haptics asynchronouslySultanxda
Blocking the timed_output sysfs node due to mutex contention causes severe device wake-up latency, as a process crucial to system resume writes to the timed_output vibrator node every time the device is resumed via the fingerprint reader (fingerprint reader triggers a haptic response on success). By processing haptics asynchronously via a worker, the timed_output sysfs won't get stalled for long periods of time (>30ms), and thus the device will consistently wake from sleep faster. Change-Id: I248ff11b79482cea804252c199b4a8935ad45fc1 Signed-off-by: Sultanxda <sultanxda@gmail.com>
2019-12-23remove calls to trace_printkThierry Strudel
Removes boot warning: trace_printk() being used. Allocating extra memory. Change-Id: I3347379da302fc273e9b1d2787863cb244837ce8 Signed-off-by: Thierry Strudel <tstrudel@google.com>
2019-12-23msm: memshare: relaese mutex if req client id is not foundDavid Lin
This fixes the smatch warning below: drivers/soc/qcom/memshare/msm_memshare.c:570 handle_alloc_generic_req() warn: inconsistent returns 'mutex:&memsh_drv->mem_share'. Bug: 35898203 Change-Id: I86f3d77c9bb471b1bc26360e11e378fa3d1a3f66 Signed-off-by: David Lin <dtwlin@google.com>
2019-12-23qcom: qmi: release mutex upon qmi_svc_event_notifier_register errorDavid Lin
This fixes the following smatch warning: drivers/soc/qcom/qmi_interface.c:2019 qmi_svc_event_notifier_register() warn: inconsistent returns 'mutex:&temp->svc_addr_list_lock'. Change-Id: I2ada7d79a0ac6b6a14abad0cb463af491dd1c319 Signed-off-by: David Lin <dtwlin@google.com>