diff options
| author | Oleg Perelet <operelet@codeaurora.org> | 2016-10-11 12:19:44 -0700 |
|---|---|---|
| committer | Oleg Perelet <operelet@codeaurora.org> | 2016-10-11 12:32:09 -0700 |
| commit | 237cd9fbf6c4f1fe14e628b27d95cd56d31ddaf9 (patch) | |
| tree | 9e5faaa557d3123c64cd3f087112c5520353228b /drivers/devfreq | |
| parent | 6bbaf84de6841abe99b14dde599f7a2f5a8f8202 (diff) | |
msm: kgsl: Remove use of uninitialized variable
During certain code execution paths dev_ab can be assigned
not initialized value.
CRs-Fixed: 1074208
Change-Id: I330a50f6d171497e5b6d3e44e8ce2b09f2d644e3
Signed-off-by: Oleg Perelet <operelet@codeaurora.org>
Diffstat (limited to 'drivers/devfreq')
| -rw-r--r-- | drivers/devfreq/governor_bw_vbif.c | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/drivers/devfreq/governor_bw_vbif.c b/drivers/devfreq/governor_bw_vbif.c index da1eefb8c94e..33e144b653d0 100644 --- a/drivers/devfreq/governor_bw_vbif.c +++ b/drivers/devfreq/governor_bw_vbif.c @@ -78,15 +78,13 @@ static int devfreq_vbif_ev_handler(struct devfreq *devfreq, case DEVFREQ_GOV_START: mutex_lock(&df_lock); df = devfreq; - if (df->profile->get_dev_status) - ret = df->profile->get_dev_status(df->dev.parent, - &stat); + if (df->profile->get_dev_status && + !df->profile->get_dev_status(df->dev.parent, &stat) && + stat.private_data) + dev_ab = stat.private_data; else - ret = 0; - if (ret || !stat.private_data) pr_warn("Device doesn't take AB votes!\n"); - else - dev_ab = stat.private_data; + mutex_unlock(&df_lock); ret = devfreq_vbif_update_bw(0, 0); |