summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRajkumar Manoharan <rmanohar@qti.qualcomm.com>2014-01-07 13:09:16 -0800
committerPrakash Dhavali <pdhavali@codeaurora.org>2014-01-18 02:43:10 -0800
commit7a0821eacbb977951ccf0100a87ad724facf1193 (patch)
tree158693b7ce89525891df91192b1ef177b9b5a330
parentc60c4586698d9cb8806c3a8b6c22ffcb88378ec4 (diff)
qcacld: Fix kernel crash when WDA_DEL_STA_SELF_RSP is timed out
The commit "qcacld: Send WDA_DEL_STA_SELF_RSP only when vdev is released in TXRX" introduced a regression. Whenever del_sta_self is timed out, interface entry is cleared in WMA handle. Later when txrx invokes the callback after timed out, it trying to access null pointer. The existing condition is incomplete. Fix that. Change-Id: I745e23718476f3ae60a364298762a3bea5ec35c5 CRs-Fixed: 592120
-rw-r--r--CORE/SERVICES/WMA/wma.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/CORE/SERVICES/WMA/wma.c b/CORE/SERVICES/WMA/wma.c
index e45f2031d680..943273dcff0a 100644
--- a/CORE/SERVICES/WMA/wma.c
+++ b/CORE/SERVICES/WMA/wma.c
@@ -2504,8 +2504,9 @@ void wma_vdev_detach_callback(void *ctx)
wma = vos_get_context(VOS_MODULE_ID_WDA,
vos_get_global_context(VOS_MODULE_ID_WDA, NULL));
- if (!wma || !iface) {
- WMA_LOGP("%s: wma %p iface %p", __func__, wma, iface);
+ if (!wma || !iface->del_staself_req) {
+ WMA_LOGP("%s: wma %p iface %p", __func__, wma,
+ iface->del_staself_req);
return;
}
param = (tpDelStaSelfParams) iface->del_staself_req;