summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRiley Andrews <riandrews@google.com>2015-09-01 12:42:07 -0700
committerTodd Kjos <tkjos@google.com>2017-07-13 15:06:26 +0000
commit0cebb407b2f431d748d9cc85cf7e4232a9223342 (patch)
treec846134c709b1de82c8c32f2e8a524a4b9e701d7
parentec49bb00cd72c190005a850a5832d2cab9aeb5ae (diff)
FROMLIST: binder: Use wake up hint for synchronous transactions.
(from https://patchwork.kernel.org/patch/9817747) Use wake_up_interruptible_sync() to hint to the scheduler binder transactions are synchronous wakeups. Disable preemption while waking to avoid ping-ponging on the binder lock. Change-Id: Ic406a232d0873662f80148e37acefe5243d912a0 Signed-off-by: Todd Kjos <tkjos@google.com> Git-commit: 443c026e90820170aa3db2c21d2933ae5922f900 Git-repo: https://android.googlesource.com/kernel/msm Signed-off-by: Omprakash Dhyade <odhyade@codeaurora.org>
-rw-r--r--drivers/android/binder.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 08cde76875d2..211262071198 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -2201,8 +2201,12 @@ static void binder_transaction(struct binder_proc *proc,
list_add_tail(&t->work.entry, target_list);
tcomplete->type = BINDER_WORK_TRANSACTION_COMPLETE;
list_add_tail(&tcomplete->entry, &thread->todo);
- if (target_wait)
- wake_up_interruptible(target_wait);
+ if (target_wait) {
+ if (reply || !(t->flags & TF_ONE_WAY))
+ wake_up_interruptible_sync(target_wait);
+ else
+ wake_up_interruptible(target_wait);
+ }
return;
err_translate_failed: